[MIRROR] Fixes footsteps runtimes, part 2 #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [NO GBP] Fixes footsteps runtimes, part 2 (#79936) ## About The Pull Request tgstation/tgstation#79903 Fixed the most common one, but there are still more of these runtimes it seems.  This should take care of all the rest. It turns out that any one of the step types keys in the list returned by `prepare_step()` can have `null` values—not just the barefoot one—so we have to check for that in every instance where we read from it. (Shown here: the list that gets returned. Note that any one of these turf vars can be `null`, aka these are the values that we need to nullcheck for) https://github.com/tgstation/tgstation/blob/4a6d2b9297a4919d967f944c6786b801e0034df8/code/datums/elements/footstep.dm#L96 ## Why It's Good For The Game Bugfix ## Changelog :cl: fix: fixed remaining footstep runtimes /:cl: * [NO GBP] Fixes footsteps runtimes, part 2 --------- Co-authored-by: Bloop <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Nov 29, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 9, 2024
* [NoGBP] Fixes Equipment Slowdown (#81352) ## About The Pull Request Fixes #81350 #81321 wasn't done as tactfully as it should have, resulting in some oddities like bolas in your pockets giving you slowdown. This PR cleans up the code and makes it work as intended. Thanks to Melbert for literally just giving me the code for this. I did test it and added proc comments so I can guarantee everything works. ## Why It's Good For The Game You shouldn't be slowed down from a bola in your pocket, and this logic is much nicer than what we had before. ## Changelog :cl: fix: Bolas in your pockets no longer slow you down. /:cl: * [NoGBP] Fixes Equipment Slowdown --------- Co-authored-by: IndieanaJones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25319
Original PR: tgstation/tgstation#79936
About The Pull Request
tgstation/tgstation#79903 Fixed the most common one, but there are still more of these runtimes it seems.
This should take care of all the rest. It turns out that any one of the step types keys in the list returned by
prepare_step()can havenullvalues—not just the barefoot one—so we have to check for that in every instance where we read from it.(Shown here: the list that gets returned. Note that any one of these turf vars can be
null, aka these are the values that we need to nullcheck for)https://github.com/tgstation/tgstation/blob/4a6d2b9297a4919d967f944c6786b801e0034df8/code/datums/elements/footstep.dm#L96
Why It's Good For The Game
Bugfix
Changelog
🆑 vinylspiders
fix: fixed remaining footstep runtimes
/:cl: